From 2183ee4806cf1878e136fea26f06f9abef9375b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20H=C3=A1jek?= Date: Thu, 2 May 2019 18:57:08 +0200 Subject: [PATCH] internal/wire: add package name to unused provider message (#162) Fixes #161 --- internal/wire/analyze.go | 2 +- internal/wire/testdata/UnusedProviders/want/wire_errs.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/wire/analyze.go b/internal/wire/analyze.go index 99ee919..e6c3d67 100644 --- a/internal/wire/analyze.go +++ b/internal/wire/analyze.go @@ -276,7 +276,7 @@ func verifyArgsUsed(set *ProviderSet, used []*providerSetSrc) []error { } } if !found { - errs = append(errs, fmt.Errorf("unused provider %q", p.Name)) + errs = append(errs, fmt.Errorf("unused provider %q", p.Pkg.Name() + "." + p.Name)) } } for _, v := range set.Values { diff --git a/internal/wire/testdata/UnusedProviders/want/wire_errs.txt b/internal/wire/testdata/UnusedProviders/want/wire_errs.txt index ca323ab..a34cab2 100644 --- a/internal/wire/testdata/UnusedProviders/want/wire_errs.txt +++ b/internal/wire/testdata/UnusedProviders/want/wire_errs.txt @@ -1,6 +1,6 @@ example.com/foo/wire.go:x:y: inject injectBar: unused provider set "unusedSet" -example.com/foo/wire.go:x:y: inject injectBar: unused provider "provideUnused" +example.com/foo/wire.go:x:y: inject injectBar: unused provider "main.provideUnused" example.com/foo/wire.go:x:y: inject injectBar: unused value of type string