From 3b6fb78a3fe4be519cebdd2469248b7cd8676ee1 Mon Sep 17 00:00:00 2001 From: Robert van Gent Date: Mon, 30 Aug 2021 17:57:05 -0700 Subject: [PATCH] tests: disable apidiff check (#316) --- internal/check_api_change.sh | 4 ++-- internal/runtests.sh | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/internal/check_api_change.sh b/internal/check_api_change.sh index 273aace..ad2f00c 100755 --- a/internal/check_api_change.sh +++ b/internal/check_api_change.sh @@ -21,11 +21,11 @@ # This script expects: # a) to be run at the root of the repository # b) HEAD is pointing to a commit that merges between the pull request and the -# upstream branch (GITHUB_HEAD_REF). +# upstream branch (GITHUB_BASE_REF). set -euo pipefail -UPSTREAM_BRANCH="${GITHUB_HEAD_REF:-master}" +UPSTREAM_BRANCH="${GITHUB_BASE_REF:-master}" echo "Checking for incompatible API changes relative to ${UPSTREAM_BRANCH}..." MASTER_CLONE_DIR="$(mktemp -d)" diff --git a/internal/runtests.sh b/internal/runtests.sh index 11f9d5f..dd56473 100755 --- a/internal/runtests.sh +++ b/internal/runtests.sh @@ -71,9 +71,10 @@ echo "Ensuring that there are no dependencies not listed in ./internal/alldeps.. # For pull requests, check if there are undeclared incompatible API changes. # Skip this if we're already going to fail since it is expensive. -if ${result} -eq 0 ]] && [[ ! -z "${GITHUB_HEAD_REF:-x}" ]]; then - echo - ./internal/check_api_change.sh || result=1; -fi +# CURRENTLY BROKEN +# if [[ ${result} -eq 0 ]] && [[ ! -z "${GITHUB_HEAD_REF:-x}" ]]; then + # echo + # ./internal/check_api_change.sh || result=1; +# fi exit $result